[FND-180] Detach Workflows Editor from current bound to Tab controller - #24477
[FND-180] Detach Workflows Editor from current bound to Tab controller#24477klaustopher wants to merge 21 commits into
Conversation
…modifies the matrix editor
072d5ff to
0b3c872
Compare
…rm but saves internally
|
Warning Flaky specs
🤖 Ask Copilot to investigateCopy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer. |
|
Before we spend more time reviewing/fixing, I guess it makes sense to run it by @oliverguenther. Wdyt? To avoid #24457 not going through the wizard exactly and having some weirdness with the workflows tabs controller having to return back to the wizard etc. This is a much bigger refactor to completely detach the workflows editor from where it is hosted, but is it worth it? |
|
@mrmir had a quick chat with Klaus on this and a code review and click through. I think it's a solid idea to move workflows into its own editing component, so we can more easily replace it later with e.g., a visual component |
|
Aah cool, y'all did that already. Will review properly then 👍🏽 |
|
Style issues are fixed @mrmir, it was simply not applying the stylesheet. And we needed to add a block display for the form so that the padding was correctly applied to make room for the save button |



Ticket
https://community.openproject.org/wp/FND-180