Skip to content

[FND-180] Detach Workflows Editor from current bound to Tab controller - #24477

Open
klaustopher wants to merge 21 commits into
devfrom
suggestion-for-fnd-180
Open

[FND-180] Detach Workflows Editor from current bound to Tab controller#24477
klaustopher wants to merge 21 commits into
devfrom
suggestion-for-fnd-180

Conversation

@klaustopher

@klaustopher klaustopher commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

@klaustopher
klaustopher force-pushed the suggestion-for-fnd-180 branch from 072d5ff to 0b3c872 Compare July 28, 2026 11:19
@klaustopher
klaustopher changed the base branch from implementation/fnd-180-clean-up-workflows-step to dev July 28, 2026 11:19
@github-actions

Copy link
Copy Markdown

Warning

Flaky specs

  • rspec ./modules/backlogs/spec/features/inbox_column_spec.rb[1:7:1]
🤖 Ask Copilot to investigate

Copy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer.

@copilot The following spec(s) are flaky in CI (first seen on PR #24477, linked for reference only):

- `rspec ./modules/backlogs/spec/features/inbox_column_spec.rb[1:7:1]`

Treat this as a standalone task, unrelated to PR #24477. Create a new branch from origin/dev and open a new pull request targeting dev — do not stack it on PR #24477 or reuse that branch.

Follow the playbook in docs/development/testing/handling-flaky-tests/README.md to find the root cause and fix the underlying race — do not skip, delete, or weaken the spec to make it pass; disabling is a last resort per the playbook, and only with a bug ticket. Verify the fix by running the spec(s) repeatedly (e.g. `script/bulk_run_rspec --run-count 10`).

If you cannot reproduce the flake or are not confident in a fix after reasonable investigation, do not fabricate a change or skip the spec to force CI green. Instead, leave the pull request in draft and document what you tried, the suspected cause, and any leads in its description, then assign @klaustopher to take over.

Once the fix is verified, title the PR after the spec(s) it fixes, and use the PR description to explain the root cause, how the change resolves it, and the before/after results. Label the PR `flaky-spec`, assign @klaustopher, and request a review from @klaustopher.
On every commit, set @klaustopher as the sole co-author with a `Co-authored-by:` trailer (use their GitHub no-reply email so it links to their account), so it is traceable who dispatched the fix.

@mrmir

mrmir commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Before we spend more time reviewing/fixing, I guess it makes sense to run it by @oliverguenther. Wdyt? To avoid #24457 not going through the wizard exactly and having some weirdness with the workflows tabs controller having to return back to the wizard etc. This is a much bigger refactor to completely detach the workflows editor from where it is hosted, but is it worth it?

@oliverguenther

Copy link
Copy Markdown
Member

@mrmir had a quick chat with Klaus on this and a code review and click through. I think it's a solid idea to move workflows into its own editing component, so we can more easily replace it later with e.g., a visual component

@mrmir

mrmir commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Aah cool, y'all did that already. Will review properly then 👍🏽

@mrmir mrmir mentioned this pull request Jul 28, 2026
3 tasks
@klaustopher klaustopher changed the title Suggestion for fnd 180 [FND-180] Detach Workflows Editor from current bound to Tab controller Jul 28, 2026
@klaustopher
klaustopher marked this pull request as ready for review July 28, 2026 12:39
Comment thread app/components/workflows/matrix_editor_component.rb Outdated
Comment thread app/components/workflows/matrix_editor_component.rb Outdated
Comment thread app/components/workflows/matrix_table_component.rb Outdated
Comment thread app/components/workflows/matrix_table_component.rb Outdated
Comment thread app/controllers/workflows/matrix_controller.rb Outdated

@mrmir mrmir left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works quite well overall. 👍🏽

What still needs to be touched is mainly cosmetic:

  1. Looks like the base element size was changed, resulting in the last row being cut off:
    Image

  2. I have no idea what happened to the left side "Current Status" label:

    Image

    vs.

    Image

Comment thread app/components/workflows/matrix_editor_component.rb Outdated
Comment thread app/helpers/workflow_helper.rb Outdated
Comment thread app/services/workflows/matrix_update_service.rb
Comment thread app/models/workflows/matrix_context.rb Outdated
Comment thread config/routes.rb Outdated
@klaustopher

Copy link
Copy Markdown
Contributor Author

Style issues are fixed @mrmir, it was simply not applying the stylesheet. And we needed to add a block display for the form so that the padding was correctly applied to make room for the save button

@mrmir mrmir left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants