Skip to content

Try setting git gem version to prevent danger error - #24484

Open
mrmir wants to merge 1 commit into
devfrom
fix/dangerfile
Open

Try setting git gem version to prevent danger error#24484
mrmir wants to merge 1 commit into
devfrom
fix/dangerfile

Conversation

@mrmir

@mrmir mrmir commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

What are you trying to accomplish?

Fix the failing dangerfile CI step

What approach did you choose and why?

Add explicit gem install git -v '< 5.0' to the dangerfile to ensure danger doesn't try to use the breaking 5.0 version

@mrmir
mrmir marked this pull request as ready for review July 28, 2026 15:41
@github-actions

Copy link
Copy Markdown

Warning

This pull request does not link an OpenProject work package.

Please add a link to the work package in the description, or reference it in the
title in square brackets, e.g. [SLUG-123] My title here.

@github-actions

Copy link
Copy Markdown

Warning

Flaky specs

  • rspec ./spec/features/activities/work_package/activities_spec.rb[1:5:2:2]
🤖 Ask Copilot to investigate

Copy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer.

@copilot The following spec(s) are flaky in CI (first seen on PR #24484, linked for reference only):

- `rspec ./spec/features/activities/work_package/activities_spec.rb[1:5:2:2]`

Treat this as a standalone task, unrelated to PR #24484. Create a new branch from origin/dev and open a new pull request targeting dev — do not stack it on PR #24484 or reuse that branch.

Follow the playbook in docs/development/testing/handling-flaky-tests/README.md to find the root cause and fix the underlying race — do not skip, delete, or weaken the spec to make it pass; disabling is a last resort per the playbook, and only with a bug ticket. Verify the fix by running the spec(s) repeatedly (e.g. `script/bulk_run_rspec --run-count 10`).

If you cannot reproduce the flake or are not confident in a fix after reasonable investigation, do not fabricate a change or skip the spec to force CI green. Instead, leave the pull request in draft and document what you tried, the suspected cause, and any leads in its description, then assign @mrmir to take over.

Once the fix is verified, title the PR after the spec(s) it fixes, and use the PR description to explain the root cause, how the change resolves it, and the before/after results. Label the PR `flaky-spec`, assign @mrmir, and request a review from @mrmir.
On every commit, set @mrmir as the sole co-author with a `Co-authored-by:` trailer (use their GitHub no-reply email so it links to their account), so it is traceable who dispatched the fix.

@toy toy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be better to add danger and git limiting to the development (or danger group) of Gemfile?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants