[AI-FSSDK] (DO NOT REVIEW) [FSSDK-12275] Skip unsupported experiment type during flag decision#439
Open
[AI-FSSDK] (DO NOT REVIEW) [FSSDK-12275] Skip unsupported experiment type during flag decision#439
Conversation
- Add Type field to Experiment entity and datafile entity - Parse type field from datafile in experiment mapper - Define supported experiment types (a/b, mab, cmab, feature_rollouts) - Update FeatureExperimentService to skip experiments with unsupported types - Experiments with empty type (not set in datafile) are still evaluated - Add unit tests for type skipping, empty type evaluation, and all supported types Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements experiment type filtering in the feature experiment service to skip unsupported experiment types during flag decision evaluation.
Changes
Typefield to theExperimentstructTypefield withjson:"type,omitempty"tag for datafile parsingTypefield from datafile to SDK entitySupportedExperimentTypesmap with values:a/b,mab,cmab,feature_rolloutsFeatureExperimentService.GetDecisionto skip experiments with unsupported typesBehavior
Typeis empty string (not set in datafile): Experiment is evaluated (backward compatible)Typeis in supported types map: Experiment is evaluatedTypeis non-empty but NOT in supported types: Experiment is skipped with debug logTest Plan
go build ./...compiles without errorsRelated
Generated with Claude Code