Adding conversion to long if integer is too big#555
Closed
iago-zwift wants to merge 1 commit intooptimizely:masterfrom
Closed
Adding conversion to long if integer is too big#555iago-zwift wants to merge 1 commit intooptimizely:masterfrom
iago-zwift wants to merge 1 commit intooptimizely:masterfrom
Conversation
Author
|
@muzahidul-opti this is my WIP to fix it. |
Contributor
Thanks for the PR. Could you please sign the agreement? link |
Author
|
@muzahidul-opti done |
Author
|
@muzahidul-opti I'm not sure why the CI failed for some of the builds. From the logs looks like something to do with CERTS. Can you please check? |
Contributor
Would you mind if I reopen a PR internally? I've raised a ticket for this link. I hope we can resolve it soon. |
Author
|
Internal PR opened for this. Will close it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
This is currently missing some testing due to lack of knowledge on the existing test suite.
Issues