[FSSDK-11143] update: Implement CMAB Client#579
Merged
FarhanAnjum-opti merged 18 commits intomasterfrom Aug 26, 2025
Merged
Conversation
…chDecision method and retry logic
…s and error handling
Contributor
muzahidul-opti
left a comment
muzahidul-opti
left a comment
There was a problem hiding this comment.
Looks good to me. Added a couple of comments.
…ethod with improved error handling and retry logic
muzahidul-opti
approved these changes
Aug 26, 2025
Contributor
muzahidul-opti
left a comment
muzahidul-opti
left a comment
There was a problem hiding this comment.
Changes look good to me with maxTimeoutMs. Added a few comments
core-httpclient-impl/src/main/java/com/optimizely/ab/cmab/DefaultCmabClient.java
Show resolved
Hide resolved
core-httpclient-impl/src/main/java/com/optimizely/ab/cmab/DefaultCmabClient.java
Show resolved
Hide resolved
core-httpclient-impl/src/main/java/com/optimizely/ab/cmab/DefaultCmabClient.java
Show resolved
Hide resolved
core-httpclient-impl/src/main/java/com/optimizely/ab/cmab/DefaultCmabClient.java
Show resolved
Hide resolved
core-httpclient-impl/src/main/java/com/optimizely/ab/cmab/DefaultCmabClient.java
Show resolved
Hide resolved
FarhanAnjum-opti
deleted the
farhan-anjum/FSSDK-11143-implement-cmab-client
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implemented DefaultCmabClient, a client for fetching CMAB (Contextual Multi-Armed Bandit) decisions.
Supports configurable retries with exponential backoff through CmabRetryConfig.
Handles error scenarios such as network failures, non-2xx responses, invalid JSON, and malformed responses.
Logs relevant error and retry information using the Optimizely logger.
Test plan
Issues