Feedback testing #13
Open
Feedback testing #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
aosingh
reviewed
Dec 12, 2025
| logging.basicConfig(level=logging.INFO) | ||
| logger = logging.getLogger(__name__) | ||
|
|
||
| PROFILE_NAME = "PYSAI_TEST_FEEDBACK_PROFILE" |
Member
There was a problem hiding this comment.
Use uuid just be safe because Github Actions runs tests concurrently and that can create concurrency issues accessing the profile. We run the testcases for multiple different Python versions in parallel.
Make sure the profile name is unique. We can use test suite id e.g. 1500 and a unique identifier.
import uuid
PROFILE_NAME = f"PYSAI_1500_{uuid.uuid4().hex.upper()}"
aosingh
reviewed
Dec 12, 2025
| ), | ||
| ), | ||
| ) | ||
| with select_ai.cursor() as cr: |
Member
There was a problem hiding this comment.
Use existing fixture for cursor. It is module level fixture.
https://github.com/oracle/python-select-ai/blob/main/tests/conftest.py#L128-L131
def profile(oci_credential, oci_compartment_id, test_env, cursor)
cursor.execute(...)
aosingh
reviewed
Dec 12, 2025
| response = "SELECT p1.name, g1.total_points FROM people p1 JOIN gymnast g1 ON p1.id = g1.id ORDER BY g1.total_points DESC" # Valid SQL on your tables | ||
| feedback_content = "print in descending order of total_points" | ||
| success = False | ||
| try: |
Member
There was a problem hiding this comment.
Please remove try..except..else block.
In case of an unknown exception, pytest will fail the testcase. And we need the full traceback for any unknown exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Feedback tests for select ai python package . It includes positive, negative, delete feedback API tests
How Has This Been Tested?
It is a test only transaction