Minor Bug Fixes and Report Corrections in Connections Module#486
Open
nishikantmandal007 wants to merge 14 commits into
Open
Minor Bug Fixes and Report Corrections in Connections Module#486nishikantmandal007 wants to merge 14 commits into
nishikantmandal007 wants to merge 14 commits into
Conversation
This was referenced Jun 20, 2026
…preference not captured or applied, dialog crash on accept, welded edge type not stored for report - Bolted: packing plate combobox was commented out in detailing_values(); restored and added KEY_DP_DETAILING_PACKING_PLATE to values dict - Bolted: KEY_DP_DETAILING_PACKING_PLATE missing from input_dictionary_design_pref(); capture_design_pref_values() silently discarded the saved value - Bolted/Welded: set_input_values() always applied packing plate regardless of Yes/No preference; guarded with use_packing flag per IS 800:2007 Cl. 10.3.3.2 - Welded: self.edgetype never set; save_design() always fell back to default edge type in report - Bolted/Welded: inherited Connection.refresh_input_dock() returned KEY_SUPTNGSEC/KEY_SUPTDSEC keys absent from Butt Joint dock; findChild() returned None causing AttributeError on .currentText(); overrode to return [] in both modules - template_page.py: added None guard before .currentText() call as second-layer defence
…s were swapped and bolted formula was inverted; correct to 5/8 x Tmin (double) and 9/8 x Tmin (single)
- Bolted set_input_values(): double cover used 9/8 (correct for single), single used 5/8 (correct for double) — values were completely swapped
- Welded set_input_values(): double cover used 9/16 (wrong fraction, slightly below 5/8), single used 5/8 (too thin for single cover)
- Bolted save_design(): LaTeX and t_req followed the same swap; corrected to frac{5}{8} for double and frac{9}{8} for single
- Welded save_design(): tcp_numerator/denominator followed the same swap; corrected to 5/8 for double and 9/8 for single
- Wrong citation "Cl. 10.2.4.2" removed; replaced with honest reference to Indian Machine Design practice (IBR) validated against IS 800:2007 Cl. 10.1
…th Butt Joint modules - Bolted: store self.n_holes and self.bolt_hole_dia in check_base_metal_strength() for report use - Bolted save_design(): add 'Gross / Net Area' row showing Ag = b × t_min and An = (b - n_h × d_0) × t_min before the capacity formula rows per IS 800:2007 Cl. 6.2 and 6.3; An row omitted for compression case - Bolted save_design(): remove silent back-calculation of An_disp; Tdn formula now shows beta = 0.7 shear lag factor explicitly per IS 800:2007 Cl. 6.3.3 - Welded save_design(): add 'Gross / Net Area' row showing Ag = b × t_min and An = Ag (no bolt holes in welded joint) per IS 800:2007 Cl. 6.2 and 6.3
…oat thickness) and wrong substituted value; correct to 2s (weld size) per IS 800:2007 Cl. 10.5.4 - save_design() Effective Length block showed L_eff = L_provided - 2a and substituted effective_throat (= 0.707s), making the printed arithmetic inconsistent with the result - Code calculation was already correct (L_eff = L_provided - 2s at line 948) - Changed formula symbol a -> s and substituted value effective_throat -> weld_size - Added IS 800:2007 Cl. 10.5.4 citation inline in the formula
…packing plate clause 10.3.3.2->10.3.3.3, fix weld L_eff dual assignment - Bolted check_base_metal_strength(): shear_lag_factor=0.7 was incorrectly applied to plate butt joints; IS 800:2007 Cl. 6.3.3 beta only applies to angles/channels connected through part of cross-section; plates have full width connected -> no shear lag -> T_dn = 0.9 * An * fu / gamma_m1 - Bolted save_design(): LaTeX Net Section Rupture formula updated to remove beta symbol and show Cl. 6.3 instead of Cl. 6.3.3 - Both modules: packing plate comment references corrected from Cl. 10.3.3.2 (large grip) to Cl. 10.3.3.3 (packing plates) - Welded weld_length(): straight weld path now applies 2s deduction per Cl. 10.5.4 instead of setting L_eff = L_provided without deduction
… access to prevent KeyError
According to IS 800:2007 Cl. 10.5.7.3, there is no absolute 70s cap on weld length. Instead, a long joint reduction factor beta_lw is applied when l_eff > 150*t_t. Removed the legacy 70s check which conflicted with the actual code.
Definitively removed the incorrect shear lag factor beta=0.7 for tension rupture of flat plates, strictly conforming to IS 800:2007 Cl. 6.3.1.
nishikantmandal007
force-pushed
the
fixes/connection_modules
branch
from
32b6b7a to
17b8937
Compare
Fixes the five Lap Joint Bolted tracker issues as one display-layer root cause: 1. Corrects reported fub for Property Class 4.6 from 459 MPa to the backend/IS 1367 value of 400 MPa. 2. Corrects the shear-capacity report formula to display the same fub used by the backend calculation. 3. Corrects the bolt design-capacity report consistency because design capacity is derived from the corrected displayed shear capacity. 4. Confirms the reported number of bolts is not based on the erroneous displayed fub and documents that backend sizing already used 400 MPa. 5. Confirms the bolt arrangement is not unsafe from this issue and documents that arrangement already came from the correct backend capacity.
- Bug 6: Corrected T_dn formula to remove incorrect 0.7 shear lag factor for full-width plate, and scaled T_dg/T_dn to kN for correct report units. - Bug 7: Utilization ratio correctly computes now since plate capacity is derived accurately. - Bug 8: design_status is explicitly set to False when overall utilization ratio exceeds 1.0. - Bug 9: number_bolts layout is forced to be consistent with layout arrangement columns/rows, and correctly displayed in the report. - Bug 10: Corrected beta_lg formula parenthesis precedence, bound beta_lg <= beta_lj, and enforce bolt recount (revalidation) after applying capacity reduction factor min(beta_lj, beta_lg).
nishikantmandal007
force-pushed
the
fixes/connection_modules
branch
from
87f84ac to
8d6670a
Compare
…uard in GUI design_fn
…hear capacity reporting
…eX report generation for Butt Joint Bolted Connection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.get()fallbacks so it no longer crashes.2a(throat thickness) instead of2s(weld size) for end returns. Fixed: Updated the LaTeX formula string to properly display2s.70son weld length, which is not specified in IS 800:2007. Fixed: Removed the artificial70slimit and now relies on the standard long joint reduction factor.