Conversation
Contributor
djLintUnclosed string found in template syntax.layouts/_partials/commons/image/helpers/GetDimensions.html, line 12:2, code T027 {{ $svgWidth := indeUnclosed string found in template syntax.layouts/_partials/commons/image/helpers/GetDimensions.html, line 13:2, code T027 {{ $svgHeight := indUnclosed string found in template syntax.layouts/_partials/commons/image/helpers/GetDimensions.html, line 18:4, code T027 {{ $svgViewBoxSizes Tag seems to be an orphan.layouts/_partials/contents/list.html, line 42:2, code H025 </div>Tag seems to be an orphan.layouts/_partials/taxonomies/section-list.html, line 9:2, code H025 <div class="taxonomi
Duplicate attribute found.layouts/alias.html, line 9:43, code H037 urlLinted 573 files, found 6 errors. Hugo analyzerDirectoriesDirectories should not contain too many files, it's probably a sign of mess.
Partials callsPartials called once might be in the wrong place. Partials never called might be metaprogrammed, or obsolete.
Too many linesFiles should not be too long, it's a sign of mess and a difficulty for overrides.
ComplexityCyclomatic complexity should not be too high.
|
Member
|
@alexisben je propose qu'on garde la convention suivante
|
Contributor
Author
Oui ! https://developers.osuny.org/docs/theme/html/structure/#nommage-et-appels-des-partiels |
arnaudlevy
changed the title
alexisben
requested review from
Olivia206,
SebouChu,
arnaudlevy and
pabois
as code owners
github-project-automation
Bot
moved this from In progress
to Done
in Refactor theme Osuny
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Description
Retirer la condition et simplifier l'appel du partiel "GetHeadingTag".
Il reste un warning lié au partiel d'image à corriger.
Niveau d'incidence