-
Notifications
You must be signed in to change notification settings - Fork 690
AO3-6916 Add devcontainer configuration #5587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
brianjaustin
wants to merge
9
commits into
otwcode:master
Choose a base branch
from
brianjaustin:AO3-6916-devcontainers
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+36
−31
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
afd3593
AO3-6916 Add devcontainer configuration
brianjaustin 8ff4e8e
AO3-6916 Use test container as well
brianjaustin 12b635c
AO3-6916 Support docker commands in codespace
brianjaustin 2388caa
AO3-6916 GitHub preview URL instead of GitPod
brianjaustin 8745ed6
AO3-6916 Fix access via codespaces preview url
brianjaustin 51f3e2c
Please??
brianjaustin e102f83
Try doing this via DInD instead
brianjaustin 6a8f795
Try specific path once again
brianjaustin 7bbc056
Fix interpolated quotes
brianjaustin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| // For format details, see https://containers.dev/implementors/json_reference/. | ||
| { | ||
| "name": "otwarchive", | ||
| "image": "mcr.microsoft.com/devcontainers/base:debian", | ||
|
|
||
| // Features to add to the dev container. More info: https://containers.dev/features. | ||
| "features": { | ||
| "ghcr.io/devcontainers/features/docker-in-docker:2": { | ||
| "moby": false | ||
| }, | ||
| "ghcr.io/devcontainers/features/github-cli:1": {} | ||
| }, | ||
|
|
||
| // Use 'forwardPorts' to make a list of ports inside the container available locally. | ||
| "forwardPorts": [], | ||
|
|
||
| // Use 'postCreateCommand' to run commands after the container is created. | ||
| "postCreateCommand": "sh script/docker/init.sh && docker compose up -d web", | ||
|
|
||
| "remoteUser": "root" | ||
| } | ||
|
|
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
|
|
@@ -75,8 +75,9 @@ services: | |||
| RAILS_ENV: development | ||||
| # Disable rack-timeout | ||||
| RACK_TIMEOUT_SERVICE_TIMEOUT: 0 | ||||
| GITPOD_WORKSPACE_ID: ${GITPOD_WORKSPACE_ID:-} | ||||
| GITPOD_WORKSPACE_CLUSTER_HOST: ${GITPOD_WORKSPACE_CLUSTER_HOST:-} | ||||
|
Comment on lines
-78
to
-79
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The devcontainer URL needs to be added to the list of allowed hosts.
|
||||
| CODESPACES: ${CODESPACES:-} | ||||
| CODESPACE_NAME: ${CODESPACE_NAME:-} | ||||
| GITHUB_CODESPACES_PORT_FORWARDING_DOMAIN: ${GITHUB_CODESPACES_PORT_FORWARDING_DOMAIN:-} | ||||
| ACTIVE_RECORD_ENCRYPTION_PRIMARY_KEY: bEZjYLY9tCYGh6WlcMtEJpIi7GO2plZC | ||||
| ACTIVE_RECORD_ENCRYPTION_DETERMINISTIC_KEY: PpLWizzsQHIWnIihtECw8nDHZQd0amzf | ||||
| ACTIVE_RECORD_ENCRYPTION_KEY_DERIVATION_SALT: 3S99KdpdEWLnCYudBgUfdCFDBWePWCud | ||||
|
|
@@ -132,7 +133,7 @@ services: | |||
| - CUCUMBER_PUBLISH_QUIET=true | ||||
| # Silence ebook-convert warning about running as root | ||||
| - QTWEBENGINE_CHROMIUM_FLAGS=--no-sandbox | ||||
| command: bundle exec cucumber | ||||
| command: sleep infinity | ||||
| volumes: | ||||
| - .:/otwa | ||||
| ports: | ||||
|
|
||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docker supports
compose.yamlnow, and it seems to be the standard based on how often it shows up in the docs