Open
Conversation
sudomateo
reviewed
Feb 17, 2026
Contributor
sudomateo
left a comment
There was a problem hiding this comment.
You'll need to regenerate the OpenAPI specification since that's what's used to generate the documentation.
| #[derive(Deserialize, JsonSchema, Serialize, PartialEq, Debug, Clone)] | ||
| pub struct AuditLog { | ||
| /// Required, inclusive | ||
| /// Start of time range (inclusive). Filters on `time_completed`. |
Contributor
There was a problem hiding this comment.
This query parameter is indeed required but not marked as required in the OpenAPI specification so it doesn't have the required badge on the rendered site. I think this is a dropshot bug?
> curl https://oxide.sys.r3.oxide-preview.com/v1/system/audit-log
{
"request_id": "7fb4332d-c9f4-4400-a863-d78749965d79",
"message": "unable to parse query string: missing field `start_time`"
}
Clarify that the `start_time` query parameter applies to `time_completed`, not `time_started`. This is a bit confusing otherwise, because an inattentive user might assume that `start_time` filters on `time_started`, since they sound alike.
5e9c09a to
0b38300
Compare
Contributor
Author
|
Bumped the version to get a new openapi doc: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify that the
start_timequery parameter applies totime_completed, nottime_started. This is a bit confusing otherwise, because an inattentive user might assume thatstart_timefilters ontime_started, since they sound alike.Feel free to close if too nit-picky. I was reading the docs and wanted to check the code to be sure of the behavior, even though this is really the only behavior that would make sense.