bootstore type reorg PR 4/?: Move latest BgpPeer and SwitchPortSettings from common to nexus-types#9909
Merged
jgallagher merged 1 commit intomainfrom Feb 24, 2026
Merged
Conversation
…s-types` This also addresses some lingering TODOs from #9568 about `From` impls being defined in the wrong place per RFD 619.
jgallagher
force-pushed
the
john/shadow-external-types-2
branch
from
8805d4e to
ec816d8
Compare
jgallagher
changed the base branch from
john/shadow-external-types-1
to
main
sunshowers
approved these changes
Feb 24, 2026
Contributor
sunshowers
left a comment
sunshowers
left a comment
There was a problem hiding this comment.
this is great, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also addresses some lingering TODOs from #9568 about
Fromimpls being defined in the wrong place per RFD 619.Part of #9801.
Staged on top of #9906.Now rebased ontomain.