contrib: Add MIME type check and flag for goshy - #81
Open
riotbib wants to merge 1 commit into
Open
Conversation
Without this information added to curl's POST request some browsers like Firefox don't display `video/mp4` inside the app, but want to download the video. If the flag is not used manually, goshy now guesses the MIME type. This adds `file` and `gawk` as dependencies for goshy. While adding those to the NixOS module I noticed that `buildInputs` didn't add the deps to the PATH; but passing those to `wrapProgram` worked. Since `bash` and `curl` are installed by default on NixOS, I guess this was never noticed. Also added `qrencode` as dep for goshy on NixOS packaging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this information added to curl's POST request some browsers like Firefox don't display
video/mp4inside the app, but want to download the video.If the flag is not used manually, goshy now guesses the MIME type.
This adds
fileandgawkas dependencies for goshy.While adding those to the NixOS module I noticed that
buildInputsdidn't add the deps to the PATH; but passing those towrapProgramworked. Sincebashandcurlare installed by default on NixOS, I guess this was never noticed.Also added
qrencodeas dep for goshy on NixOS packaging.