Skip to content

fix(docs): add a note about bundling and merge_pr_in_ci - #1165

Open
mfocko wants to merge 1 commit into
packit:mainfrom
mfocko:fix/PACKIT-5184
Open

fix(docs): add a note about bundling and merge_pr_in_ci#1165
mfocko wants to merge 1 commit into
packit:mainfrom
mfocko:fix/PACKIT-5184

Conversation

@mfocko

@mfocko mfocko commented Aug 13, 2026

Copy link
Copy Markdown
Member

Fixes packit/packit#2733
Fixes PACKIT-5184

Since there is no reply on the issue, I’m adding a note to the docs and closing down the issue.

Fixes packit/packit#2733
Fixes PACKIT-5184

Signed-off-by: Matej Focko <mfocko@packit.dev>
@fullsend-ai-review

fullsend-ai-review Bot commented Aug 13, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 8:15 AM UTC · Completed 8:28 AM UTC

Commit: b168edc · View workflow run →

@centosinfra-prod-github-app

Copy link
Copy Markdown
Contributor

@fullsend-ai-review

Copy link
Copy Markdown

Review

Findings

Low

  • [scope-vs-intent] docs/configuration/index.md:178 — The linked issue (prepare-sources fails with "local changes would be overwritten" when PR modifies vendored files packit#2733) reports a code bug in packit's prepare-sources path where git checkout main fails on vendored files due to .gitattributes line-ending normalization. This PR closes the issue by documenting a workaround (merge_pr_in_ci: false) rather than applying a code fix. Per maintainer analysis in the issue comments, the forced-checkout code fix was deliberately declined as too risky. Consider keeping the issue open to track the underlying defect, or noting the resolution rationale in the issue comments before closing.

Labels: PR adds documentation about the merge_pr_in_ci configuration key

RPM packages with an NVR referencing an unknown hash (the one created by the
Packit merge commit).

:::tip Packages with bundled dependencies

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] scope-vs-intent

The linked issue (packit/packit#2733) reports a code bug in packit's prepare-sources path where git checkout main fails on vendored files. This PR closes the issue by documenting a workaround (merge_pr_in_ci: false) rather than fixing the code. Per maintainer analysis in the issue comments, the code fix approach was deliberately declined. Consider keeping the issue open or noting the resolution rationale before closing.

Suggested fix: Either keep the issue open and remove the Fixes closer from the PR body, or note the resolution rationale in the issue comments before closing.

@fullsend-ai-review fullsend-ai-review Bot added ready-for-merge All reviewers approved — ready to merge kind/documentation Improvements to docs area/config Related to the configuration labels Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config Related to the configuration kind/documentation Improvements to docs ready-for-merge All reviewers approved — ready to merge

Projects

Development

Successfully merging this pull request may close these issues.

prepare-sources fails with "local changes would be overwritten" when PR modifies vendored files

2 participants