-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Release version 8.3.1 #3109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release version 8.3.1 #3109
Conversation
|
@davidism can you please review this. |
|
Actually maybe not. This release causes failures in Flasks test suite. |
|
@kdeldycke can you look at this issue in Flasks test suite. If we know that 8.3.1 is going to have something major broken, then better to hold the release and fix it. |
I can confirm that Flask's tests don't fail with click 8.3.0. |
|
Minimal example of pallets/flask#5836. is #3136 |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
8.3.1 is a quasi-release and 8.3.0 has regressions, so destabilise and mask 8.3.0 too (8.3.1 was done in af95459). Bug: https://bugs.gentoo.org/964910 Bug: pallets/click#3087 Bug: pallets/click#3109 Signed-off-by: Sam James <[email protected]>
|
This is on hold until #3136 is patched. |
|
I just proposed a fix to the last remaining issue at: #3137 |
|
I ran flask's test suite with click's latest stable branch and they all pass, so everything looks good. |
|
@davidism Can you please review and approve the upload job. |
|
@davidism fixed. |
|
Let's rebase to squash these commits, then re-tag. |
51bd25d to
1d038f2
Compare
No description provided.