Extract _guess_type from convert_type and add overloads#3372
Merged
Conversation
AndreasBackx
approved these changes
Apr 24, 2026
Collaborator
AndreasBackx
left a comment
AndreasBackx
left a comment
There was a problem hiding this comment.
Thanks for pulling this out!
kdeldycke
force-pushed
the
convert-type-refactor
branch
from
37a90d5 to
c314f96
Compare
Collaborator
Author
|
No conflict so far, so this PR is ready to be review/merged for 8.4 inclusion. |
Collaborator
|
@kdeldycke Change log entry please. So it sounds like you want there to be an 8.4 release? If so, works for me. I appreciate the back log clearing you have done. |
Collaborator
|
If so, I can change all the current prs to merge into main. |
Collaborator
|
Saw all the new PRs and milestone. Let do 8.4.0 as next release. |
This is a refactor that was original part of `typing/paramtype` branch but split out of pallets#3371 to keep the latter focused on typing only. Co-authored-by: Kevin Deldycke <kevin@deldycke.com>
kdeldycke
force-pushed
the
convert-type-refactor
branch
from
c314f96 to
b2bfd55
Compare
Collaborator
Author
|
Just fix the merging issue. This PR is ready. |
Collaborator
|
@kdeldycke or @AndreasBackx can you add a changelog entry. |
Collaborator
Author
Covered in #3393 |
kdeldycke
added a commit
to kdeldycke/click
that referenced
this pull request
Apr 30, 2026
kdeldycke
added a commit
to kdeldycke/click
that referenced
this pull request
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a refactor that was original part of
typing/paramtypebranch by @AndreasBackx, then split out of #3371 to keep the latter focused on typing only.It is kept in its separate PR to untied it from pure typing improvements from #3371 and further study and evaluation.