Reject invalid base64 characters#426
Closed
CodingFeng101 wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
base64_decode()now rejects non-ASCII input and characters outside the URL-safe base64 alphabet before adding padding and decoding.Why
The previous path encoded text with
errors="ignore", so non-ASCII characters were silently dropped before decoding. Python's base64 decoder is also permissive about some non-alphabet characters. For signed payloads, malformed base64 input should be rejected rather than normalized by dropping characters.Validation
PYTHONPATH=src python -m pytest tests\test_itsdangerous\test_encoding.py -qPYTHONPATH=src python -m pytest -qpython -m ruff check src\itsdangerous\encoding.py tests\test_itsdangerous\test_encoding.pypython -m ruff format --check src\itsdangerous\encoding.py tests\test_itsdangerous\test_encoding.pygit diff --check