Only highlight control escapes in RegExp#1195
Open
kevinoid wants to merge 1 commit intopangloss:masterfrom
Open
Only highlight control escapes in RegExp#1195kevinoid wants to merge 1 commit intopangloss:masterfrom
kevinoid wants to merge 1 commit intopangloss:masterfrom
Conversation
The `\\c + ASCII letter` escape sequence is not specified as part of the [EscapeSequence] production in the grammar for strings. It behaves like any other unspecified character by ignoring the backslash. The escape sequence is only specified as part of the [CharacterEscape] production in the grammar for RegExp patterns, where it matches a character with the letter's codepoint mod 32 (which is the same for uppercase and lowercase ASCII letters). Update the syntax to highlight both uppercase and lowercase letters in RegExp and neither in strings. [CharacterEscape]: https://www.ecma-international.org/ecma-262/#prod-CharacterEscape [EscapeSequence]: https://www.ecma-international.org/ecma-262/#prod-EscapeSequence Signed-off-by: Kevin Locke <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
\\c + ASCII letterescape sequence is not specified as part of the EscapeSequence production in the grammar for strings. It behaves like any other unspecified character by ignoring the backslash. The escape sequence is only specified as part of the CharacterEscape production in the grammar for RegExp patterns, where it matches a character with the letter's codepoint mod 32 (which is the same for uppercase and lowercase ASCII letters).This PR updates the syntax to highlight both uppercase and lowercase letters in RegExp and neither in strings.
Thanks for considering,
Kevin