reporter: Upload symbols only if in given allowlist#3035
Open
metalmatze wants to merge 1 commit intomainfrom
Open
reporter: Upload symbols only if in given allowlist#3035metalmatze wants to merge 1 commit intomainfrom
metalmatze wants to merge 1 commit intomainfrom
Conversation
Member
Author
|
Relevant logs for this feature. |
umanwizard
approved these changes
Feb 27, 2025
metalmatze
force-pushed
the
reporter-upload-allowlist
branch
from
2271455 to
1f66082
Compare
If an allowlist is given Parca Agent will only upload symbols for binaries matching the strings that are specific. The match happens with `strings.Contains`. So `parca` matches both `parca` and `parca-agent`.
metalmatze
force-pushed
the
reporter-upload-allowlist
branch
from
1f66082 to
193ad94
Compare
brancz
reviewed
Mar 17, 2026
| var allowed bool | ||
| for _, s := range r.symbolUploadAllowlist { | ||
| if strings.Contains(args.FileName, s) { | ||
| log.Infof("executable found in allowlist, file: '%s' matches '%s'", args.FileName, s) |
| // Config holds all the configuration information for Parca Agent. | ||
| type Config struct { | ||
| RelabelConfigs []*relabel.Config `yaml:"relabel_configs,omitempty"` | ||
| SymbolUpload SymbolUpload `yaml:"symbol_upload,omitempty"` |
Member
There was a problem hiding this comment.
I find it odd to place this here, seems more appropriate to be a flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an allowlist is given Parca Agent will only upload symbols for binaries matching the strings that are specific. The match happens with
strings.Contains. Soparcamatches bothparcaandparca-agent.