fix(astro-swiper): format DemoEffectCards component and refine s effect#19
Closed
devzom wants to merge 1 commit intopascal-brand38:mainfrom
Closed
fix(astro-swiper): format DemoEffectCards component and refine s effect#19devzom wants to merge 1 commit intopascal-brand38:mainfrom
devzom wants to merge 1 commit intopascal-brand38:mainfrom
Conversation
devzom
force-pushed
the
fix/swiper-cardeffects-use-native-shadow
branch
from
43410db to
2717c59
Compare
devzom
force-pushed
the
fix/swiper-cardeffects-use-native-shadow
branch
from
2717c59 to
3522cfb
Compare
Owner
|
@devzom thanks a lot to have pointed out this css hack. This makes the code harder to understand. However, your fix does not work. With this PR, the background is grey for all slides, because it is set in .my-slide, and the hack has been removed. Also, swiperjs demo does not use I have proposed in #20 another refactoring, that removes the css-hack, and makes the code more straightforward. Let me know... |
Owner
|
@devzom what do you think of this solution? |
Author
|
Hey, my bad, I've missed that. ;) let's go ahead with your solution:) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #18