Skip to content

Fixed crash when not using any extra arguments #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
patrick-kidger wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed crash when not using any extra arguments #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[project]
name = "typst_pyimage"
version = "0.0.4"
version = "0.0.5"
description = "Typst extension, adding support for generating figures using inline Python code"
readme = "README.md"
requires-python = "~=3.8"
Expand Down
1 change: 1 addition & 0 deletions typst_pyimage/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ def _watch_wrapper(args):
"-a",
"--extra-args",
type=str,
default="",
help="Extra arguments to be passed to typst",
)

Expand Down
8 changes: 2 additions & 6 deletions typst_pyimage/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,11 +156,9 @@ def _initial(

def watch(
filename: Union[str, pathlib.Path],
extra_args: Optional[list[str]] = None,
extra_args: list[str],
timeout_s: Optional[int] = None,
):
if extra_args is None:
extra_args = []
figcache = {}
contentcache = {}
filepath, dirpath, init_code, init_scope = _initial(
Expand Down Expand Up @@ -190,8 +188,6 @@ def watch(
process.kill()


def compile(filename: Union[str, pathlib.Path], extra_args: Optional[list[str]] = None):
if extra_args is None:
extra_args = []
def compile(filename: Union[str, pathlib.Path], extra_args: list[str]):
filepath, _, _, _ = _initial(filename, figcache=None, contentcache=None)
subprocess.run(["typst", "compile"] + extra_args + [str(filepath)])