feat(banner): add pf-v6-banner#3143
Open
zeroedin wants to merge 1 commit into
Open
Conversation
|
Contributor
✅ Commitlint tests passed!More Info{
"valid": true,
"errors": [],
"warnings": [],
"input": "feat(banner): add pf-v6-banner"
} |
Contributor
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2983
pf-v6-bannerelement ported from pf-v5-banner and aligned with the React v6 Banner componentvariantattribute with separatecolor(8 decorative colors) andstatus(5 semantic statuses) attributes, matching React's split APIscreen-reader-textattribute for visually-hidden status announcements (WCAG 1.3.1)stickyattribute (maps to ReactisSticky)iconattribute/slot — icons are now composed in the default slot, matching React v6light-dark()for standalone usageDeviations from React
pf-v5-icon: The status demo composes icons in the default slot usingpf-v5-iconbecausepf-v6-iconis not yet merged tostaging/pfv6. Once pf-v6-icon lands, the status demo should be updated to usepf-v6-iconwith therh-ui-*-fillicon set to match the React demos visually.isStickyas a prop but no dedicated demo on patternfly.org. We include a standalone sticky demo since the behavior requires scrollable content to verify — this was carried forward from the v5 element.Test plan
/review-a11y— no critical issues/review-api— no critical issues/review-demos— all demos match patternfly.org paritycem health— 87/100 (above 80% threshold)http://localhost:8000/elements/banner/demo/{slug}?rendering=chromeless🤖 Generated with Claude Code