fix(Tables): updated animations to beta - #11927
Merged
Merged
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-11927.surge.sh A11y report: https://patternfly-react-pr-11927-a11y.surge.sh |
edonehoo
reviewed
Jul 17, 2025
| 2. Wrap the content of each child row cell in `ExpandableRowContent`. | ||
| 3. Enclose each parent/child row pair in a `Tbody` component with an `isExpanded` prop. | ||
| 1. Wrap the content of each child row cell in `ExpandableRowContent`. | ||
| 1. Pass `isExpanded` to `Tbody` and the `Tr` that contains expandable content, and `isContentExpanded` to the `Tr` that acts as the "control row". |
Contributor
There was a problem hiding this comment.
Suggested change
| 1. Pass `isExpanded` to `Tbody` and the `Tr` that contains expandable content, and `isContentExpanded` to the `Tr` that acts as the "control row". | |
| 1. Pass `isExpanded` to `Tbody` and the `Tr` containing expandable content, and pass `isContentExpanded` to the `Tr` that acts as the "control row". |
| 2. Wrap the content of each child row cell in `ExpandableRowContent`. | ||
| 3. Each child `Tr` has an `isExpanded` prop. | ||
| 1. Wrap the content of each child row cell in `ExpandableRowContent`. | ||
| 1. Pass `isExpanded` to `Tbody` and the `Tr` that contains expandable content, and `isContentExpanded` to the `Tr` that acts as the "control row". |
Contributor
There was a problem hiding this comment.
Suggested change
| 1. Pass `isExpanded` to `Tbody` and the `Tr` that contains expandable content, and `isContentExpanded` to the `Tr` that acts as the "control row". | |
| 1. Pass `isExpanded` to `Tbody` and the `Tr` containing expandable content, and pass `isContentExpanded` to the `Tr` that acts as the "control row". |
Comment on lines
203
to
204
| 1. Pass `isExpandable` to `Table` | ||
| 1. Make the first cell in every row an expandable cell by passing `TdExpandType` object to the `expand` prop on the `Td` |
Contributor
There was a problem hiding this comment.
Suggested change
| 1. Pass `isExpandable` to `Table` | |
| 1. Make the first cell in every row an expandable cell by passing `TdExpandType` object to the `expand` prop on the `Td` | |
| 1. Pass `isExpandable` to `Table`. | |
| 1. Make the first cell in every row an expandable cell by passing `TdExpandType` object to the `expand` prop on the `Td`. |
Comment on lines
230
to
231
| 1. Pass `isExpandable` to `Table` | ||
| 1. Pass a `TdCompoundExpandType` object to the `compoundExpand` prop on any `Td` that has an expandable child row |
Contributor
There was a problem hiding this comment.
Suggested change
| 1. Pass `isExpandable` to `Table` | |
| 1. Pass a `TdCompoundExpandType` object to the `compoundExpand` prop on any `Td` that has an expandable child row | |
| 1. Pass `isExpandable` to `Table`. | |
| 1. Pass a `TdCompoundExpandType` object to the `compoundExpand` prop on any `Td` that has an expandable child row. |
edonehoo
approved these changes
Jul 17, 2025
kmcfaul
requested changes
Jul 17, 2025
kmcfaul
approved these changes
Jul 17, 2025
thatblindgeye
marked this pull request as ready for review
July 17, 2025 15:33
nicolethoen
approved these changes
Jul 17, 2025
kmcfaul
approved these changes
Jul 17, 2025
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #
Additional issues: