feat(package): dual module support - #11933
Conversation
|
Preview: https://patternfly-react-pr-11933.surge.sh A11y report: https://patternfly-react-pr-11933-a11y.surge.sh |
| import { treeRow } from './utils'; | ||
| import { mergeProps } from './base/merge-props'; | ||
| import { IVisibility } from './utils/decorators/classNames'; | ||
| import { Tooltip } from '@patternfly/react-core/dist/esm/components/Tooltip/Tooltip'; |
There was a problem hiding this comment.
This is worth pointing out and thinking about - with the new export format, it appears that directory level imports and file level imports cannot exist simultaneously and be resolved successfully (component wildcard patterns end up interfering with each other).
Currently, only directory imports are supported so file imports like the above Tooltip won't work and would need to be updated. There are several of these type of imports reported in our analytics. Still investigating if that can be updated to support both.
| import QuestionCircleIcon from '@patternfly/react-icons/dist/esm/icons/question-circle-icon'; | ||
| import EllipsisVIcon from '@patternfly/react-icons/dist/esm/icons/ellipsis-v-icon'; | ||
| import imgAvatar from '@patternfly/react-core/src/components/assets/avatarImg.svg'; | ||
| // import imgAvatar from '../components/assets/avatarImg.svg'; |
There was a problem hiding this comment.
Look at inlining this.
|
This will be on hold until a breaking change release, so will be closed for now. |
3 participants
What: Closes #11686
Assisted-by: Cursor
First pass on dual module package.json.
react-icons,react-tokens, andreact-stylesare not currently included because of what we output to the dist & what our docs expects when consuming our repos. Need to investigate further to see if we can adjust without breaking.