Merged
Conversation
Shubham N Khanna (shubham-n-khanna)
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some Heimdall payloads do not produce a result, but the current Caterpillar Heimdall Task implementation always hits the /result API. This causes issues with certain payloads, particularly SQL DDL.
This PR introduces a new field
GetResult, which determines whether or not we want to hit the /result endpoint after completion of a job. This is intentionally different from theReturnResultwhich has different behaviors depending on how the heimdall plugin was written. For example, Trino ALWAYS returns a result, regardless of whether or not ReturnResult is used. Because of this, having a separate indicator for how we poll the heimdall API is essential.To test this, I tested the following pipeline:
Both with
get_resultand without it.Types of changes
Checklist