chore: replace zip file reader to io reader#56
Merged
Mayuresh Pawar (Mayureshpawar29) merged 2 commits intomainfrom Apr 3, 2026
Merged
chore: replace zip file reader to io reader#56Mayuresh Pawar (Mayureshpawar29) merged 2 commits intomainfrom
Mayuresh Pawar (Mayureshpawar29) merged 2 commits intomainfrom
Conversation
Made-with: Cursor
Mayuresh Pawar (Mayureshpawar29)
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaced
fs.Read(buf)withio.ReadFull(fs, buf)in the zip archive unpack (Read) function.Go's
io.Reader.Read()is not guaranteed to fill the entire buffer in a single call — it may return fewer bytes than requested even before EOF. For large files inside a ZIP archive, this results in truncated/partial data padded with null bytes.io.ReadFullloops internally until exactlylen(buf)bytes are read, ensuring complete data extraction.Types of changes
Checklist