fix: prevent zombie WebSocket when destroy() called during init#1360
Open
dearlordylord wants to merge 1 commit intopeers:masterfrom
Open
fix: prevent zombie WebSocket when destroy() called during init#1360dearlordylord wants to merge 1 commit intopeers:masterfrom
dearlordylord wants to merge 1 commit intopeers:masterfrom
Conversation
dearlordylord
force-pushed
the
fix/zombie-websocket-after-destroy
branch
from
f22fd88 to
9eb0599
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
new Peer()is created without an ID,retrieveId()fires an async HTTP request.If
destroy()is called before it resolves,_initialize()runs unconditionally on the destroyed peer, creating a WebSocket that sends heartbeats indefinitely with no event listeners and no API path to close it.Add a guard in
_initialize()to return early if the peer is destroyed or disconnected. Also guard the async error handlers inretrieveId()andlistAllPeers()to suppress spurious error events on dead peers.potentially related to #789