Open
Conversation
missinglink
requested changes
Jul 7, 2023
Member
missinglink
left a comment
missinglink
left a comment
There was a problem hiding this comment.
Hi, thanks for your contribution.
Could you please remove the empty sections in pelias.json and add some unit tests as per the other countries.
After that I'd be happy to merge this PR.
| "interpolation": { "url": "http://interpolation:4300" }, | ||
| "libpostal": { "url": "http://libpostal:4400" } | ||
| }, | ||
| "defaultParameters": { |
Member
There was a problem hiding this comment.
please remove this section defaultParameters
| "files": [ | ||
| ] | ||
| }, | ||
| "csv": { |
Member
There was a problem hiding this comment.
please remove this empty section csv
| "adminLookup": { | ||
| "enabled": true | ||
| }, | ||
| "blacklist": { |
Member
There was a problem hiding this comment.
please remove this empty section blacklist
| "importPlace": [ | ||
| ] | ||
| }, | ||
| "interpolation": { |
Member
There was a problem hiding this comment.
please remove this empty section interpolation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 Hi, I have started a project to onboard Bangladesh in Pelias and start improving address system for Bangladesh. appreciate your help!