Pin ruff to <0.16 to fix CI lint failures - #293
Merged
Conversation
ruff 0.16 expanded its default lint rule selection, causing CI to install a newer ruff than the local dev environment and surface ~1900 new findings unrelated to this branch's changes. Pin the dev dependency to keep CI aligned with the previously passing rule set until the rule selection is deliberately updated.
Owner
Author
|
@claude please check SQL injection risk |
mcp 2.0 removed/renamed the Server.list_tools/call_tool decorator API that src/soa_builder/mcp/server.py relies on. pyproject.toml only required mcp>=1.0.0 with no upper bound, so CI installed 2.0.0 while local dev stayed on 1.28.1, breaking pytest collection for the whole test suite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pyproject.tomlpinned onlyruff>=0.5.0with no upper bound, CI picked up 0.16.2 while local dev environments stayed on 0.15.x.CI (Python)onmaster(and previously on PR Release v 1.6 #291).ruff>=0.5.0,<0.16so CI stays aligned with the rule set that was actually passing, until the rule selection is deliberately revisited.Test plan
CI (Python)passes on this PR across all Python versions (3.11–3.14)