Fix deleting contacts by external_id via API - #552
Open
JoeJoeflyn wants to merge 1 commit into
Open
Conversation
`external_id` was missing from the `@fields` list in `Keila.Contacts.Query`, so filtering by `external_id` (which the delete API endpoint does when `id_type=external_id`) silently matched nothing. Adds `external_id` to `@fields` so the filter builds a valid query. Closes pentacent#548.
JoeJoeflyn
force-pushed
the
fix/delete-by-external-id
branch
from
July 27, 2026 11:43
b08a89a to
c40e628
Compare
Contributor
|
Thanks for finding this bug and fixing it! I saw you signed the CLA in the other PR, so I'll merge this after that one has been merged. |
Author
|
tks, appreciate it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
external_idwas missing from the@fieldslist inKeila.Contacts.Query, so filtering byexternal_id(which the delete API endpoint does whenid_type=external_id) silently matched nothing and the contact was not deleted.Adds
external_idto@fieldsso the filter builds a valid query.Closes #548.