[BACKLOG-48508] - add projectDir to CRUD APIs

[abryant-hv]

No description provided.

[Copilot]

Pull request overview

This PR extends the Data Access Connection REST API to accept an optional projectDir query parameter on connection CRUD operations, enabling callers (and potential subclasses) to run operations in a project-scoped context.

Changes:

• Added optional projectDir query parameter to relevant CRUD endpoints in connection-api.yaml.
• Updated ConnectionService CRUD method signatures to include projectDir, and added overloads for backward compatibility.
• Centralized ConnectionServiceException → WebApplicationException mapping via a helper method and adjusted some member visibility for subclassing.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File	Description
core/src/main/resources/connection-api.yaml	Adds projectDir query parameter to CRUD endpoints and tweaks response descriptions.
core/src/main/java/org/pentaho/platform/dataaccess/datasource/wizard/service/impl/ConnectionService.java	Updates CRUD API method signatures to accept projectDir, adds backward-compatible overloads, and refactors exception handling.

Comments suppressed due to low confidence (3)

core/src/main/resources/connection-api.yaml:94

• The 200 response description says the body will be empty, but the response schema is IDatabaseConnection (i.e., a non-empty JSON body is documented). Please align the description and the documented response content (either remove the response body schema or update the description to indicate an IDatabaseConnection is returned).

        '200':
          description: Successfully created database connection. The body will be empty. 
          content:
            application/json:
              schema:
                $ref: '#/components/schemas/IDatabaseConnection'

core/src/main/resources/connection-api.yaml:224

• This 200 response is documented with text/plain string content, but the description says the body will be empty. If the endpoint returns an empty string (as a body) then document that explicitly; otherwise remove the response body content to match an empty-body 200 response.

        '200':
          description: Successfully deleted connection. The body will be empty.
          content:
            text/plain:
              schema:
                type: string
        '304':

core/src/main/resources/connection-api.yaml:260

• This endpoint’s 200 response includes text/plain string content, but the description says the body will be empty. Please reconcile the OpenAPI contract (either document that the body is an empty string or remove the response body content if it’s truly empty).

        '200':
          description: Successfully added connection. The body will be empty. 
          content:
            text/plain:
              schema:
                type: string

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

[hitachivantarasonarqube]

Quality Gate passed

Issues

• 0 New Issues
• 5 Fixed Issues
• 1 Accepted Issue

Measures

• 0 Security Hotspots
• 82.20% Coverage (28.20% Estimated after merge)
• 0.00% Duplicated Code (5.10% Estimated after merge)

Project ID: pentaho:pentaho-data-access-parent

View in SonarQube

[buildguy]

Note:

---

Frogbot also supports Contextual Analysis, Secret Detection, IaC and SAST Vulnerabilities Scanning. This features are included as part of the JFrog Advanced Security package, which isn't enabled on your system.

---

🐸 JFrog Frogbot

[buildguy]

✅ Build finished in 20m 48s

Build command:

mvn clean verify -B -e -Daudit -Djs.no.sandbox -pl core

---

👌 All tests passed!

Tests run: 419, Failures: 0, Skipped: 1    Test Results

---

ℹ️ This is an automatic message

[abryant-hv]

Superseded by #1346