PG-2240 Add pg_upgrade support for encrypted tables#522
PG-2240 Add pg_upgrade support for encrypted tables#522jeltz wants to merge 2 commits intopercona:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (60.14%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #522 +/- ##
==========================================
+ Coverage 60.06% 60.14% +0.08%
==========================================
Files 68 68
Lines 10677 10680 +3
Branches 1835 1837 +2
==========================================
+ Hits 6413 6424 +11
+ Misses 3557 3552 -5
+ Partials 707 704 -3
🚀 New features to boost your workflow:
|
|
Looks like Also the commit message is a little hard to read. Which "data directory" needs to be copied? I think the actual behavior change here needs to be presented first, and then we can talk about the added test and why the pg_tde/ directory (not the data directory) needs to be copied in it. I don't think we should make assertions on the "cp" command, it should be assumed to work imho. |
To safely run pg_upgrade with SMGR encryption enabled people need to first copy the data directory and then we have changed pg_tde so that it no longer overwrites or deletes keys when ran in binary upgrade mode. Encrypted WAL is still not supported in pg_upgrade and it may also make sense to write a script which automates copying the pg_tde directory.
The test is partially included to showcase the steps necessary to get pg_upgrade working with encrypted WAL.
To safely run
pg_upgradewith SMGR encryption enabled people need to first copy the data directory and then we have changedpg_tdeso that it no longer overwrites or deletes keys when ran in binary upgrade mode.Encrypted WAL is still not supported in
pg_upgradeand it may also make sense to write a script which automates copying thepg_tdedirectory.