Don't require a verifiable mock that an inner-scope default mock shadows#2751
Draft
nohwnd wants to merge 1 commit into
Draft
Don't require a verifiable mock that an inner-scope default mock shadows#2751nohwnd wants to merge 1 commit into
nohwnd wants to merge 1 commit into
Conversation
…t mock shadows A mock marked -Verifiable in an outer scope that is overridden by a mock for the same command in a narrower scope could never pass Should -InvokeVerifiable, because Get-VerifiableBehaviors still collected the outer behavior and reported it as never invoked even though the inner mock handled every call. Walk the scopes from the test outwards and drop a verifiable behavior when a closer scope has a default mock (no -ParameterFilter) for the same command. A verifiable mock that isn't shadowed is still required. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2672
A mock marked
-Verifiablein an outer scope (Describe/Context) that you then override with another mock for the same command in an inner scope (It) could never passShould -InvokeVerifiable: the inner mock handled the call, butGet-VerifiableBehaviorsstill collected the outer one and reported it as never invoked.Get-VerifiableBehaviorsnow walks the scopes from the test outwards and drops a verifiable behavior when a closer scope has a default mock (one without a-ParameterFilter) for the same command - that default catches every call, so the outer behavior can't run and shouldn't be required. A verifiable mock that isn't shadowed like that is still required, same as before.