Enumerate non-IList collections (hashtable keys/values) in Should -Be#2753
Merged
Conversation
Should -Be reported two equal collections as different when they were a non-IList enumerable such as [hashtable].Keys/.Values. ArraysAreEqual took its arguments as [object[]], and binding such a collection to an [object[]] parameter wraps it as a single element instead of enumerating it, so the counts never matched. Take the arguments as [object] and enumerate them with @() inside the function, which expands these collections correctly while leaving strings and hashtables as single values. Arrays, scalars and nested arrays compare exactly as before. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
nohwnd
force-pushed
the
fix/1200-enumerate-collections
branch
from
fa1bc8a to
7af4e49
Compare
Add Queue, Stack, SortedSet and generic Dictionary cases to the #1200 tests, and a generic List case to guard the IList path that already worked. The collection has to be the -Be argument to hit the bug, since the piped side is always enumerated by the pipeline. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1200
Should -Bereported two equal collections as different when they were a non-IList enumerable such as the one returned by[hashtable].Keys/.Values.ArraysAreEqualtakes its arguments as[object[]], and binding such a collection to an[object[]]parameter wraps it as a single element instead of enumerating it - so the actual value had two items and the expected value had one, and the counts never matched.Take the arguments as
[object]and enumerate them with@()inside the function, which expands these collections correctly while still leaving strings and hashtables as single values. Arrays, scalars and nested arrays compare exactly as before.