Fall back to no dynamic parameters when a mocked command can't produce them#2755
Merged
Conversation
…n't produce them Mocking a command whose dynamic parameters can't be resolved while it is mocked failed the whole mock with `Cannot retrieve the dynamic parameters for the cmdlet`. Set-PSRepository is the reported case: its -Location parameter is built and validated from the package provider, which throws when Pester re-runs the dynamicparam block to copy the parameter metadata onto the mock. Pester only needs that metadata to forward the call, so when retrieving it fails - from a cmdlet's IDynamicParameters or a function's dynamicparam block - fall back to no dynamic parameters instead of failing. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #619
Mocking a command whose dynamic parameters can't be resolved while it's mocked failed the whole mock with "Cannot retrieve the dynamic parameters for the cmdlet. ...". The reported case is
Set-PSRepository: its-Locationparameter is built (and validated) from the package provider, and that validation throws when Pester re-runs the dynamicparam block to copy the parameter metadata onto the mock.Pester only needs that metadata to forward the call, so when retrieving it fails - either from a cmdlet's
IDynamicParametersor a function'sdynamicparamblock - fall back to no dynamic parameters instead of failing the mock. The mock then works as long as the call doesn't use one of those parameters (the issue's repro doesn't use-Location).