Remove Pathogen::Icon and standardize icon rendering#17
Merged
Conversation
joshsadam
changed the title
ericenns
requested changes
Apr 2, 2026
Member
ericenns
left a comment
ericenns
left a comment
There was a problem hiding this comment.
This is mostly working, except that the following previews throw errors:
Contributor
Author
Updated the instructions, need to run |
joshsadam
force-pushed
the
phase-3.5-remove-pathogen-icon-20260327-134314
branch
from
f716544 to
2a7a054
Compare
joshsadam
changed the title
joshsadam
changed the title
ChrisHuynh333
previously approved these changes
Apr 29, 2026
- remove Pathogen icon component classes and icon stylesheet - remove icon preview class and all icon preview templates
- drop nokogiri and rails_icons from gemspec dependencies - remove icon helper mapping and icon stylesheet/readme references
- remove rails_icons lock entry and direct dependency linkage - align lockfile with gemspec dependency removals from task 2
- add 03.5-01 execution summary with checkpoint and verification notes - update state, roadmap, and requirements tracking for completed plan
- replace Pathogen::Icon instantiation in ButtonVisuals#icon_visual - normalize icon names from underscore to dash for rails_icons lookup
- add 03.5-03 summary with verification, decisions, and self-check - update STATE.md progress, metrics, decision log, and current position - mark ICON-03 complete in REQUIREMENTS.md
- add direct rails_icons dependency to demo Gemfile - generate rails_icons initializer configured for heroicons
- add magnifying-glass outline SVG for leading_visual preview - add arrow-right outline SVG for trailing_visual preview
- add 03.5-02 summary with verification outcomes and deviation log - update state metrics/session context for 03.5-02 completion - mark icon phase roadmap and ICON-02 requirement as complete
This reverts commit 0a2289d.
- Remove inline style attributes for consistent styling - Use Tailwind utilities (layout/typography/spacing) throughout preview
- Sync generated design tokens/utilities with current build output
joshsadam
force-pushed
the
phase-3.5-remove-pathogen-icon-20260327-134314
branch
from
f1b50fc to
5b91609
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do and why?
This PR removes the internal
Pathogen::Iconcomponent and related icon support code from the gem. It updates button visuals and demo previews to usehelpers.icondirectly, and moves therails_iconssetup into the demo app so Lookbook previews still render.Screenshots or screen recordings
No visual changes expected.
How to set up and validate locally
bin/setup.bundle exec rubocop.bin/test.demo/, runbin/setup, thenbin/dev.http://localhost:3001/lookbookand verify the button, tabs, tooltip, and typography previews still render icons without missing asset errors.PR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.