Conversation
- Replace Lightning bundle with Tailwind CLI and pathogen.tailwind.css. - Add datagrid companion layer and regenerate pathogen_view_components.css. - Remove legacy app/assets/stylesheets/pathogen/* sources.
- Replace BEM pathogen-* markup with utilities and data-* hooks where needed. - Align Stimulus tabs and data-grid scroll behavior with new selectors. - Bump gem to 1.0.0 for the styling contract change.
- Update selectors and class expectations for grids, forms, and typography. - Adjust Stimulus controller fixtures for tooltip and tabs.
- Describe the pre-built Tailwind pipeline and build:css:check in the root README. - Point the Lookbook demo at pathogen.tailwind.css and the parent pnpm scripts.
- Eliminate the Tailwind pipeline comments as the demo now utilizes the Pathogen CSS build pipeline. - Update documentation to reflect the new CSS build process.
- Modify the dev script to run from the demo app root, allowing Foreman to load the correct Procfile and resolve relative paths accurately. - Implement logic to determine the script's execution path, enhancing reliability when navigating directories.
- Introduce a descriptive comment in the Callout class to clarify its purpose within the Pathogen Typography System.
Align Pathogen CSS with Tailwind theme variables and update generated stylesheet layers.
Update component class generation, previews, and tests to match the new Tailwind theme contract.
- Removed unused border and background color classes from CSS. - Updated button scheme classes to reflect new color mappings. - Adjusted tests to verify the correct application of updated color classes.
- Replaced slate color classes with neutral equivalents in CSS and button component. - Removed unused slate scheme from button options. - Updated checkbox styles to align with new neutral color scheme. - Adjusted tests to reflect the removal of slate scheme assertions.
…over effects - Added new neutral background and border color classes for hover states in CSS. - Updated button component to utilize the new neutral color scheme and hover effects. - Adjusted tests to verify the correct application of updated color classes in button rendering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do and why?
pathogen_view_components.cssartifact (host apps do not need to run Tailwind).Screenshots or screen recordings
How to set up and validate locally
bin/setuppnpm installpnpm run build:css:check(orpnpm run build:cssto regenerate the artifact)bin/testpnpm testcd demo && bundle install && bin/dev, then openhttp://localhost:3001/lookbookPR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.