fix issue #85 - #86
Open
HenrikEngen wants to merge 1 commit into
Open
Conversation
petterroea
requested changes
Sep 1, 2026
| return { | ||
| 'uuid': str(self.uuid), | ||
| 'user_uuid': self.user_uuid, | ||
| 'name': self.user.firstname + " " + self.user.lastname, |
Contributor
There was a problem hiding this comment.
This is generally bad practice. name is not a field on store session, and so it does not belong there. Return a simplified version of the user object instead, see how the mappers are used.
I suggest you take inspiration from https://github.com/phoenixlan/phoenixapi-v1/blob/master/phoenixRest/mappers/user.py#L32 but make a new map_user_public without position_mappings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About this pull request
Fix #85
Dependencies
None
Prerequisites