Added new function to view all ticket transfers for a ticket - #87
Open
HenrikEngen wants to merge 3 commits into
Open
Added new function to view all ticket transfers for a ticket#87HenrikEngen wants to merge 3 commits into
HenrikEngen wants to merge 3 commits into
Conversation
HenrikEngen
changed the title
petterroea
reviewed
Sep 1, 2026
petterroea
left a comment
petterroea
left a comment
Contributor
There was a problem hiding this comment.
Looks like security isn't set up here.
| }), status=403) | ||
|
|
||
| # Test to read transfer log for a ticket as privileged user, expects 200 (Security check) and one log entry (Functionality check) | ||
| transferlog_privileged = testapp.get('/ticket/%s/transfer_log' % transfer_ticket['ticket_id'], headers=dict({ |
Contributor
There was a problem hiding this comment.
Does everyone ever involved with the ticket see the ticket? Or only admins?
Member
Author
There was a problem hiding this comment.
The full transferlog is meant to only be visible to administrators.
The "first" user should not be able to view the whole transfer chain, only the transfer between "first" and "second".
I believe the code is correct? Can you verify?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About this pull request
Let ticket admins and admins view all ticket transfers.
Dependencies
None
Prerequisites