use 1.0.0 as the default statement version

[xabbuh]

No description provided.

[Lctrs]

Why not do this during the serialization as done with the objectType of the Actor model ?

[xabbuh]

The serialiser is also used by the client. If we implemented it the, the client would always send a statement containing a version.

[Lctrs]

Then, why not setting it at the storage level, before storing a statement ?

[xabbuh]

We could, but that would be inconsistent with how we did handle other constraints till now (for example, we check for already existing statements inside the bundle but not in the storage layer).

[Lctrs]

This means we can have stored statements which lack a version, which is not fully compliant with the spec.

I'm not sure I'm okay with this. It can be hard then to manage statements at different version as the spec evolves.

[xabbuh]

That's true. But then I suggest that we look at the bundle again and check which other logic should better be move to the storage layer too (and add tests for the things to the php-xapi/repository-api package.

[Lctrs]

For what it's currently implemented, I think we should move the check for existing statements inside the storeStatement method of the Statement repository.

With the current implementation, the library allow a behavior that is not compliant with the spec.

Looking at the LRS implementation from ADL, they do this check for both POST and PUT requests.

[Lctrs]

Plus, I just noticed that we are not currently checking for the existence of a voided Statement. Maybe we should add a method to the StatementRepositoryInterface that can retrieve both voided and non-voided statements ?