Skip to content

Fix GH-20767: build failure with preserve_none attribute enabled on mac. #20777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devnexen wants to merge 5 commits into
base: PHP-8.5
Choose a base branch
from
Open

Fix GH-20767: build failure with preserve_none attribute enabled on mac. #20777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bbc2260
Fix GH-20767: build failure with preserve_none attribute enabled on mac.
devnexen Dec 25, 2025
9327fb3
enabling for the rest
devnexen Dec 25, 2025
404f602
apply suggestion
devnexen Dec 25, 2025
43c03c4
apply arnaud suggestion
devnexen Dec 26, 2025
7ae196a
trying @petk suggestion
devnexen Dec 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Zend/Zend.m4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,6 +476,13 @@ AC_DEFUN([ZEND_CHECK_PRESERVE_NONE], [dnl
AC_CACHE_CHECK([for preserve_none calling convention],
[php_cv_preserve_none],
[AC_RUN_IFELSE([AC_LANG_SOURCE([[

#ifdef __apple_build_version__
# if __apple_build_version__ < 17000404
# error This version of Apple Clang doesn't support preserve_none
# endif
#endif

#include <stdio.h>
#include <stdint.h>

Expand Down
3 changes: 3 additions & 0 deletions Zend/zend_portability.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,10 +336,13 @@ char *alloca();
# define ZEND_PRESERVE_NONE __attribute__((preserve_none))
#endif


#if !defined(__apple_build_version__) || (defined(__apple_build_version__) && __apple_build_version__ >= 17000404)
#if __has_attribute(musttail)
# define HAVE_MUSTTAIL
# define ZEND_MUSTTAIL __attribute__((musttail))
#endif
#endif

#if (defined(__GNUC__) && __GNUC__ >= 3 && !defined(__INTEL_COMPILER) && !defined(__APPLE__) && !defined(__hpux) && !defined(_AIX) && !defined(__osf__)) || __has_attribute(noreturn)
# define HAVE_NORETURN
Expand Down