Fix GH-19088: Make sscanf %c read whitespace#22041
Open
prateekbhujel wants to merge 3 commits into
Open
Conversation
Keep the %c conversion separate from %s so it reads whitespace instead of stopping at it. The %c conversion already suppresses leading whitespace skipping; it also must not treat whitespace as the end of the field.
devnexen
reviewed
May 14, 2026
devnexen
reviewed
May 14, 2026
acdb609 to
08ea8fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes GH-19088.
%calready disables the usual leading whitespace skip, but after that it still reused the%sscan path, which stops as soon as it sees whitespace. That madesscanf(' ', '%c%n', ...)assign an empty string and leave the offset at 0.Keep
%cseparate from%sin the scan loop so it consumes the requested number of characters, including spaces. The same scanner is used byfscanf(), so the existing%cexpectations there are updated as well.Tests run: