-
Notifications
You must be signed in to change notification settings - Fork 546
Speedup analysis of arrays containing closures #4684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request has been marked as ready for review. |
|
this PR will not close phpstan/phpstan#13933 because the reproducer was not representable (see discussion in the linked issue) -- after rebasing this PR onto the yesterdays changes the test got 1 second slower, which is caused by d8decc8 |
degrade analysis precision to a callable type
I reverted it because it's really tricky to remember there's a cache when changing something about OptimizedDirectorySourceLocator. I'd accept revert of the revert (so that the cache is on disk even for tests), but OptimizedDirectorySourceLocatorTest should have a special .neon file where it's memory cache again. |
|
Thank you! |
alternative implementation to #4680
degrade analysis precision to a callable type
refs phpstan/phpstan#13933
before this PR
after this PR
before this PR
after this PR