NodeScopeResolver: Move assignByReference logic out of generic path #4711
+17
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Jan 4, 2026
| } | ||
|
|
||
| if (isset($parameters) && $parametersAcceptor !== null) { | ||
| foreach ($args as $i => $arg) { |
Contributor
Author
There was a problem hiding this comment.
I did not yet understand why we iterate all args twice inside of processArgs(), but if possible, I guess we could save quite some time in case we could it do just once
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this logic was executed for every expression, while we only need when
!$argValue instanceof Variable || $argValue->name !== 'this'.processArgsconsumes 17% of overall runtime. lets try to not do unnecessary stuff again and again