-
Notifications
You must be signed in to change notification settings - Fork 574
Add multi-variant overloads for PDOStatement::fetchAll() in function signature map
#5630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
staabm
merged 3 commits into
phpstan:2.1.x
from
phpstan-bot:create-pull-request/patch-8ctq654
May 11, 2026
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
5e20c36
Add multi-variant overloads for `PDOStatement::fetchAll()` in functio…
VincentLanglet 5f47180
Add tests for PDOStatement implementing IteratorAggregate and Travers…
phpstan-bot 40af5b8
Revert "Add tests for PDOStatement implementing IteratorAggregate and…
staabm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| <?php // lint >= 8.0 | ||
|
|
||
| namespace Bug5509; | ||
|
|
||
| class Foo | ||
| { | ||
| public function test(\PDOStatement $stmt): void | ||
| { | ||
| // FETCH_CLASS with class name and constructor args - should not error | ||
| $stmt->fetchAll(\PDO::FETCH_CLASS, \stdClass::class, [new \stdClass]); | ||
|
|
||
| // FETCH_CLASS with just class name - should not error | ||
| $stmt->fetchAll(\PDO::FETCH_CLASS, \stdClass::class); | ||
|
|
||
| // FETCH_COLUMN with column number - should not error | ||
| $stmt->fetchAll(\PDO::FETCH_COLUMN, 0); | ||
|
|
||
| // FETCH_FUNC with callable - should not error | ||
| $stmt->fetchAll(\PDO::FETCH_FUNC, function () { | ||
| return 'test'; | ||
| }); | ||
|
|
||
| // No args - should not error | ||
| $stmt->fetchAll(); | ||
|
|
||
| // With just mode - should not error | ||
| $stmt->fetchAll(\PDO::FETCH_ASSOC); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the docs on https://www.php.net/manual/en/class.pdostatement.php
I can see
can we make more tests out of that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added tests for
PDOStatementimplementingIteratorAggregateandTraversableas the reviewer requested:foreachiteration overPDOStatementgetIterator()onPDOStatementPDOStatementtoTraversableandIteratorAggregatetypehintsAll tests pass (12044 tests, 79632 assertions) and
make phpstanreports no errors.