minimal corrections to avoid implicit nullable deprecation warning#116
Merged
kylekatarnls merged 1 commit intophug-php:masterfrom Mar 7, 2025
dealfonso:implicit-nullable
Merged
minimal corrections to avoid implicit nullable deprecation warning#116kylekatarnls merged 1 commit intophug-php:masterfrom dealfonso:implicit-nullable
kylekatarnls merged 1 commit intophug-php:masterfrom
dealfonso:implicit-nullable
Conversation
Contributor
Author
|
Please create a new release to update packagist |
Member
|
This is a breaking change because it drops support for PHP < 7.1, it will go in the next major release. For now you can use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found a lot of warnings related to "Implicitly marking parameter XXX as nullable is deprecated, the explicit nullable type must be used instead" when trying to use Phug in PHP8.4.
The warnings have been corrected by marking explicitly as nullable those parameters that default to null.
The process was assisted by using Rector, with the following code:
Fix #115