Correct 500 error on topics#show and topics#destroy#69
Open
lfzawacki wants to merge 11 commits intophusion:masterfrom
Open
Correct 500 error on topics#show and topics#destroy#69lfzawacki wants to merge 11 commits intophusion:masterfrom
lfzawacki wants to merge 11 commits intophusion:masterfrom
Conversation
…n/juvia Conflicts: app/views/api/_comment.html.erb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The methods show! and destroy! were invalid in the topics controller, they were probably intended to be used with a gem like 'inherited_resources' but instead of adding it I just rewrote the methods without it. I included some tests for the controller to make sure I'm not breaking anything.
Also while running the tests I found that 'db:seed' failed because the data was an invalid devise user, so I just made a little correction to the data there.