Skip to content

Address PR#16 feedback: terminology, consolidation, and security improvements#13

Draft
Copilot wants to merge 3 commits intofull-rewritefrom
copilot/resolve-pr-feedback-16
Draft

Address PR#16 feedback: terminology, consolidation, and security improvements#13
Copilot wants to merge 3 commits intofull-rewritefrom
copilot/resolve-pr-feedback-16

Conversation

Copy link

Copilot AI commented Nov 25, 2025

Resolves reviewer feedback from netdata#16.

Terminology & Versioning

  • Renamed netdata_release_versionnetdata_release_channel with support for stable, edge, nightly (normalized to edge)
  • Changed role_version from 1.0.00.1.0 (pre-1.0 versioning)

Security

  • Added explicit GPG key ID 9DD4A74CECFA8F4F to apt_key task to prevent MITM attacks

Efficiency

  • New handler uses netdatacli reload-claiming-state instead of full service restart for claiming config updates

Code Consolidation

  • Merged install-ubuntu.yml into install-debian.yml (identical, both use apt)
  • Removed empty vars/main.yml
  • Removed .gitignore (personal convenience only)
  • Removed default insecure = 'no' from claim.conf.j2
  • Removed unnecessary charts.d.conf configuration block (enabled by default)

Fixes

  • Restored period in CODEOWNERS first line
  • Fixed operator precedence in distribution conditionals
  • Added error handling to reload handler

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/ansible/ansible-lint/releases/latest
    • Triggering command: /home/REDACTED/.local/bin/ansible-lint ansible-lint --version (http block)
    • Triggering command: /home/REDACTED/.local/bin/ansible-lint ansible-lint --exclude tests/test.yml --skip-list=role-name (http block)
  • repo.netdata.cloud
    • Triggering command: /usr/bin/curl curl -s REDACTED (dns block)
    • Triggering command: /usr/bin/curl curl -sL REDACTED (dns block)
    • Triggering command: /usr/bin/wget wget -q REDACTED -O netdata.key (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

Resolve the PR feedback from netdata#16


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits November 25, 2025 22:11
…onfiguration

Co-authored-by: pid1 <4173362+pid1@users.noreply.github.com>
…, and line length

Co-authored-by: pid1 <4173362+pid1@users.noreply.github.com>
Copilot AI changed the title [WIP] Resolve PR feedback for pull request 16 Address PR#16 feedback: terminology, consolidation, and security improvements Nov 25, 2025
Copilot AI requested a review from pid1 November 25, 2025 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants