Support for multiple cookies with the same name from different domains - #113
Open
zachasme wants to merge 4 commits into
Open
Support for multiple cookies with the same name from different domains#113zachasme wants to merge 4 commits into
zachasme wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #88.
I've added a
getAll()method instead of adding amultioption toget()such that the return type doesn't depend on input (which will also lead to saner typescript definitions).The biggest question is how multiple signed cookies with same name should work when one signature is invalid. I went with removing the signature cookie if any of the signature cookies fail to match a key.
What do you think is the best approach?