Improving imagemagick security - #255
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an ImageMagick policy to restrict dangerous SVG processing paths.
Changes:
- Adds coder and path restrictions.
- Installs the policy in the container image.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
files/conf/imagemagick/policy.xml |
Defines the hardened policy. |
Dockerfile |
Copies the policy into the image. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request strengthens the security of ImageMagick in the container by introducing a hardened policy configuration. The new policy restricts potentially dangerous coders and paths that SVG assets could exploit, mitigating risks such as remote code execution, local file reads, and server-side request forgery when processing untrusted SVG uploads.
Security hardening for ImageMagick:
policy.xmlto/etc/ImageMagick-7/to deny file-read, text, scripting, and network coders that SVGxlink:hrefcan invoke, reducing the attack surface for untrusted SVG assets.Dockerfileto copy the hardenedpolicy.xmlinto the ImageMagick configuration directory during the build process.