Studio Frontend Build: scope push trigger to version branches (fix cancelled (push) checks) - #3929
Draft
berfinyuksel wants to merge 1 commit into
Draft
Studio Frontend Build: scope push trigger to version branches (fix cancelled (push) checks)#3929berfinyuksel wants to merge 1 commit into
berfinyuksel wants to merge 1 commit into
Conversation
The build workflow triggered on both push and pull_request. On a PR branch both events fire and resolve to the same concurrency group, so cancel-in-progress cancels one of them — surfacing as confusing cancelled "(push)" checks and a red "some checks were not successful" on PRs even though the pull_request run passed. Scope the push trigger to version branches (which have no PR); PR/feature branches are covered by pull_request. Each branch now triggers exactly one run: visible, green, no self-cancellation, and no non-fast-forward race.
Contributor
There was a problem hiding this comment.
Pull request overview
Scopes frontend build push events to version branches, preventing duplicate PR builds and concurrency cancellations.
Changes:
- Adds version-branch filters for
2026.x- and2026.2-style branches. - Documents why feature branches rely on
pull_request.
|
berfinyuksel
marked this pull request as draft
July 23, 2026 10:21
berfinyuksel
marked this pull request as ready for review
July 24, 2026 08:31
berfinyuksel
marked this pull request as draft
July 24, 2026 09:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Studio Frontend Build triggers on both
pushandpull_request. On a PR branch, both events fire and resolve to the same concurrency group (studio-frontend-build-<branch>), socancel-in-progresscancels one — showing up as cancelled(push)checks and a red "Some checks were not successful" on the PR, even though thepull_requestrun passed. Confusing for everyone opening PRs.Fix
Scope the
pushtrigger to version branches (which have no PR and still need build+commit). Feature/PR branches are covered bypull_request. Result: each branch triggers exactly one run — visible, green, no self-cancellation, and no non-fast-forward race.No behavior loss: a feature branch just builds via its PR instead of via a redundant push run.
Part of the studio frontend CI standardization (pimcore/product-management#1302).